[production/RRFS.v1] Adds modifications to speed up RUCLSM #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
items once and reuse, rather than recomputing in each call to RUCLSM.
Collaborator
Author
|
Have it linked up in https://github.com/MatthewPyle-NOAA/ufs-weather-model/tree/feature/ruclsmspeedup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes:
Computes the TBQ table only once at the first call, and reuses the values in subsequent calls to RUCLSM rather than recomputing the same item repeatedly.
Tests Conducted:
Was tested in a canned RRFS case on WCOSS, and was a zero-diff change that sped things up by several percent in terms of run time.
Dependencies:
Add any links to parent PRs (e.g. SCM and/or UFS PRs) or submodules (e.g. rte-rrtmgp). For example:
Documentation:
Issue (optional):
Contributors (optional):
@dkokron provided this code speedup.